Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAITDS-143 - Pulsar Job support to Terraform #173

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

ThiagoYU
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Zach-Johnson Zach-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just noted a few small things

ns1/resource_pulsar_job.go Outdated Show resolved Hide resolved
ns1/resource_pulsar_job.go Outdated Show resolved Hide resolved
ns1/resource_pulsar_job.go Outdated Show resolved Hide resolved
ns1/resource_pulsar_job.go Outdated Show resolved Hide resolved
ns1/resource_pulsar_job.go Outdated Show resolved Hide resolved
Copy link

@mvkushnir mvkushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! Just one final comment

website/docs/r/pulsar_job.html .markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@Zach-Johnson Zach-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Zach-Johnson Zach-Johnson merged commit 2403d7e into ns1-terraform:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants